Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint_d: repackage using buildNpmPackage #234166

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

ehllie
Copy link
Contributor

@ehllie ehllie commented May 26, 2023

Description of changes

Repackages nodePackages.eslint_d to be built using buildNpmPackage as per the suggestion in #229475

Things done

Moved eslint_d to pkgs/development/tools, removed it from node-packages.json and included it in aliases.nix.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ehllie
Copy link
Contributor Author

ehllie commented May 26, 2023

I've noticed the aliases have a comment next to them indicating when they were added. Are they supposed to be the time the change gets merged into nixpkgs, in which case I can't tell make that comment when creating the PR, or just when the PR gets submitted?

@SuperSandro2000
Copy link
Member

The date is the time of writing. It is not important that it is exact to the date as it only gets used later to know if the alias entry is 10 months or 10 days old. With the next stable cycle it should be converted to a throw and with the one after that be removed.

Apply suggestions from code review

Co-authored-by: Sandro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants