Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGo{Module,Package}: remove input argument "tags" #234537

Merged
merged 2 commits into from
May 30, 2023
Merged

buildGo{Module,Package}: remove input argument "tags" #234537

merged 2 commits into from
May 30, 2023

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 28, 2023 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@zowoq zowoq added the 2.status: work-in-progress This PR isn't done label May 28, 2023
@zowoq zowoq mentioned this pull request May 28, 2023
Merged
12 tasks
@zowoq zowoq removed the 2.status: work-in-progress This PR isn't done label May 28, 2023
@zowoq
Copy link
Contributor Author

zowoq commented May 29, 2023

@ShamrockLee I've rebased this so it can be merged as is.

@zowoq zowoq marked this pull request as ready for review May 29, 2023 00:02
@zowoq zowoq requested review from kalbasit and Mic92 as code owners May 29, 2023 00:02
@ShamrockLee
Copy link
Contributor

@ofborg build pet podman-tui lnch zrepl

@zowoq zowoq marked this pull request as draft May 30, 2023 06:26
zowoq and others added 2 commits May 30, 2023 22:05
@zowoq zowoq marked this pull request as ready for review May 30, 2023 12:08
@zowoq zowoq merged commit aea73ad into NixOS:staging May 30, 2023
@zowoq zowoq deleted the go-cleanup branch May 30, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShamrockLee ShamrockLee ShamrockLee approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zowoq @ShamrockLee