pharo: old -> 10.0.5

[jthulhu]

Description of changes

The Pharo packages were waaaaay outdated (~10 years old). This is a first attempt to update the packages.

• Pharo launcher: the launcher has been deleted from the repo, but hasn't been updated, because the version previously packaged is not compatible with the newly packaged Pharo (at least, I haven't been able to make it work)
• Pharo VMs:
  • Spur 64: this has been packaged to version 10.0.5 (which is the latest version available, not to be confused with the version of the Pharo image).
  • Spur 32: this hasn't been packaged; it shouldn't be hard (just changing the source url and the checksum), but it hasn't been done.
  • Cog 32: this is obsolete, so it has been entirely removed.

For this reason, the availability of the Pharo packaged has regressed (only linux x86_64 is supported in this PR).

While this builds and works, any attempt at using Cairo will throw an exception. This should be fixed.

Important: the previous maintainer has been removed from the maintainer list, since this packaged was clearly not maintained anymore.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-download-from-url-while-packaging-for-nixpkgs/29159/1

[jthulhu]

Cairo support has been added and tested.

[drupol]

Hi !

Thanks for your contribution.

I've left some comments, left me know if this is clear enough.

[jthulhu]

@drupol the requested changes were pretty straightforward (thanks for the examples!).

[drupol]

Thanks for implementing the changes.

Last thing, could you sort alphabetically the lambda parameters, the buildInputs, nativeBuildInputs and the meta attributes ?

Don't forget to squash your commits so that this PR only contains 1 single commit.

[jthulhu]

I have sorted the field, changed the platform and squashed into a single commit.

[drupol]

I forgot one last nit.

I usually recommend to use makeBinaryWrapper by default since it has a much better compatibility with Darwin platforms.

[jthulhu]

I have replaced makeWrapper with makeBinaryWrapper, but currently this package is not darwin-compatible, because it explicitly fetches sources that are made for Linux (although this is pretty easy to fix).

The reason there is a distinction is that Pharo needs to bootstrap itself (Pharo is written in Pharo), and to do so without an available VM the CI provides a translation of the Pharo VM in C; and their translation is target-specific, AFAIK.

[drupol]

LGTM now.

I see that you removed a bunch of entries (pharo-vms, pharo-cog32, etc etc)... shoudln't you add something in aliases.nix to let the users know that they doesn't exist anymore? And eventually a message in the release note ?

[jthulhu]

I have added the removed packages to aliases.nix, although the previous version was so severely outdated that I doubt anyone was still using it...

Besides that, how can I add a message in the release note?

[drupol]

Here's an example on how to add an entry in the release note.

The file you need to edit is nixos/doc/manual/release-notes/rl-2311.section.md

[drupol]

Could you please rebase your PR so there's only one commit?

[jthulhu]

@drupol I'm not sure if I properly rebased, now it looks like it wants to merge 68 commits... I merged from master, then I rebased to move my commit to the end.

[RaitoBezarius]

@drupol I'm not sure if I properly rebased, now it looks like it wants to merge 68 commits... I merged from master, then I rebased to move my commit to the end.

You failed your rebase and pinged other people, please remove those commits.

[jthulhu]

I'm not too sure how to resolve this merge. If I simply merge, that makes 2 commits and git refuses to amend the previous commit. If I try to rebase, it forcefully inserts commits from master into my branch.

[RaitoBezarius]

I'm not too sure how to resolve this merge. If I simply merge, that makes 2 commits and git refuses to amend the previous commit. If I try to rebase, it forcefully inserts commits from master into my branch.

Read the CONTRIBUTING guide on mass pings and retargetting, it is relevant to the problem I imagine.

[drupol]

Hi,

Here's a couple of steps that should help you fixing the current issue:

0. cd /home/.../nixpkgs
1. git checkout master
2. git remote add upstream [email protected]:NixOS/nixpkgs.git
3. git fetch --all
4. git reset upstream/master --hard
5. git push
6. git checkout update-pharo
7. git rebase master
8. git push -f

[jthulhu]

Is there a way to unping the two contributors that were accidentally added as reviewers?

[drupol]

LGTM !