gcc: builder overhaul #238069
Closed
gcc: builder overhaul #238069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
10 tasks
added 9 commits
July 7, 2023 16:14
This commit causes gcc/common/builder.nix to substitute the Nix
variable `targetConfig` directly into the build script rather than
having bash access it via variable reference.
This also eliminates some fairly cryptic bash-wizardry ${like:+this}
that most people don't grok at first sight.
|
Rebased. |
ofborg
bot
requested review from
Ericson2314,
prusnak,
SuperSandro2000,
Synthetica9,
vcunat,
adevress and
veprbl
|
Rebased, still WIP. |
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP follow-up to
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)