Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib-ng: 2.0.7 -> 2.1.2, minizip-ng: 3.0.10 -> 4.0.0 #238978

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

fpletz
Copy link
Member

@fpletz fpletz commented Jun 21, 2023

Description of changes

https://github.com/zlib-ng/zlib-ng/releases/tag/2.1.2
https://github.com/zlib-ng/minizip-ng/releases/tag/4.0.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Mindavi
Copy link
Contributor

Mindavi commented Jul 4, 2023

gtest might need to go into buildInputs instead:

$ nix-build -A pkgsCross.aarch64-multiplatform.zlib-ng
-- Performing Test HAVE_ATTRIBUTE_VISIBILITY_HIDDEN
-- Performing Test HAVE_ATTRIBUTE_VISIBILITY_HIDDEN - Success
-- Performing Test HAVE_ATTRIBUTE_VISIBILITY_INTERNAL
-- Performing Test HAVE_ATTRIBUTE_VISIBILITY_INTERNAL - Success
-- Performing Test HAVE_ATTRIBUTE_ALIGNED
-- Performing Test HAVE_ATTRIBUTE_ALIGNED - Success
-- Performing Test HAVE_THREAD_LOCAL
-- Performing Test HAVE_THREAD_LOCAL - Success
-- Performing Test HAVE_BUILTIN_CTZ
-- Performing Test HAVE_BUILTIN_CTZ - Success
-- Performing Test HAVE_BUILTIN_CTZLL
-- Performing Test HAVE_BUILTIN_CTZLL - Success
-- Performing Test HAVE_PTRDIFF_T
-- Performing Test HAVE_PTRDIFF_T - Success
-- Performing Test ARM_AUXV_HAS_CRC32
-- Performing Test ARM_AUXV_HAS_CRC32 - Success
-- Performing Test HAVE_ACLE_FLAG
-- Performing Test HAVE_ACLE_FLAG - Success
-- Performing Test MFPU_NEON_AVAILABLE
-- Performing Test MFPU_NEON_AVAILABLE - Success
-- Performing Test NEON_HAS_LD4
-- Performing Test NEON_HAS_LD4 - Success
-- Architecture-specific source files: arch/arm/arm_features.c;arch/arm/crc32_acle.c;arch/arm/insert_string_acle.c;arch/arm/adler32_neon.c;arch/arm/chunkset_neon.c;arch/arm/compare256_neon.c;arch/arm/slide_hash_neon.c
-- Disabling zlib-ng tests because shared libraries are enabled
-- The CXX compiler identification is GNU 12.3.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/draqbxxniyj662095cay7zz9gi15wshq-aarch64-unknown-linux-gnu-stage-final-gcc-wrapper-12.3.0/bin/aarch64-unknown-linux-gnu-g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR GTEST_MAIN_LIBRARY) 
CMake Error at /nix/store/f8inixjb36rcxvjwsghqlqqxgbrdrvly-cmake-3.26.4/share/cmake-3.26/Modules/ExternalProject.cmake:2806 (message):
  error: could not find git for clone of googletest-populate
Call Stack (most recent call first):
  /nix/store/f8inixjb36rcxvjwsghqlqqxgbrdrvly-cmake-3.26.4/share/cmake-3.26/Modules/ExternalProject.cmake:4208 (_ep_add_download_command)
  CMakeLists.txt:23 (ExternalProject_Add)


-- Configuring incomplete, errors occurred!

CMake Error at /nix/store/f8inixjb36rcxvjwsghqlqqxgbrdrvly-cmake-3.26.4/share/cmake-3.26/Modules/FetchContent.cmake:1610 (message):
  CMake step for googletest failed: 1
Call Stack (most recent call first):
  /nix/store/f8inixjb36rcxvjwsghqlqqxgbrdrvly-cmake-3.26.4/share/cmake-3.26/Modules/FetchContent.cmake:1762:EVAL:2 (__FetchContent_directPopulate)
  /nix/store/f8inixjb36rcxvjwsghqlqqxgbrdrvly-cmake-3.26.4/share/cmake-3.26/Modules/FetchContent.cmake:1762 (cmake_language)
  test/CMakeLists.txt:157 (FetchContent_Populate)


-- Configuring incomplete, errors occurred!

I'll probably try to fix this myself in a couple of days, but just a heads-up for anyone who wants to nerd-snipe me :)

(should probably also set strictDeps to more easily detect this in a native build too)

@Mindavi Mindavi mentioned this pull request Jul 5, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants