-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.torch: drop submodules in favor of Nixpkgs #239291
Draft
ConnorBaker
wants to merge
10
commits into
NixOS:master
Choose a base branch
from
ConnorBaker:feat/torch-use-system-libs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Aug 22, 2023
-
This change which involves creating multiple outputs for CUDA redistributable packages. We use a script to find out, ahead of time, the outputs each redist package provides. From that, we are able to create multiple outputs for supported redist packages, allowing users to specify exactly which components they require. Beyond the script which finds outputs ahead of time, there is some custom code involved in making this happen. For example, the way Nixpkgs typically handles multiple outputs involves making `dev` the default output when available, and adding `out` to `dev`'s `propagatedBuildInputs`. Instead, we make each output independent of the others. If a user wants only to include the headers found in a redist package, they can do so by choosing the `dev` output. If they want to include dynamic libraries, they can do so by specifying the `lib` output, or `static` for static libraries. To avoid breakages, we continue to provide the `out` output, which becomes the union of all other outputs, effectively making the split outputs opt-in.
Connor Baker committedAug 22, 2023 Configuration menu - View commit details
-
Copy full SHA for cc29e78 - Browse repository at this point
Copy the full SHA cc29e78View commit details -
python3Packages.torch: enable USE_SYSTEM_LIBS
Connor Baker committedAug 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 15b05e1 - Browse repository at this point
Copy the full SHA 15b05e1View commit details -
google-benchmark: remove as duplicate of gbenchmark
Connor Baker committedAug 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 0e4dd6f - Browse repository at this point
Copy the full SHA 0e4dd6fView commit details -
Connor Baker committed
Aug 22, 2023 Configuration menu - View commit details
-
Copy full SHA for a3425a1 - Browse repository at this point
Copy the full SHA a3425a1View commit details -
Connor Baker committed
Aug 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 0121e8c - Browse repository at this point
Copy the full SHA 0121e8cView commit details -
Connor Baker committed
Aug 22, 2023 Configuration menu - View commit details
-
Copy full SHA for f496d74 - Browse repository at this point
Copy the full SHA f496d74View commit details -
Connor Baker committed
Aug 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 1097f47 - Browse repository at this point
Copy the full SHA 1097f47View commit details -
onnx: update to support abseil CXX language standard requirement
Connor Baker committedAug 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 062a9c4 - Browse repository at this point
Copy the full SHA 062a9c4View commit details -
libtorch: work on some cuda refactoring
Connor Baker committedAug 22, 2023 Configuration menu - View commit details
-
Copy full SHA for faaf22c - Browse repository at this point
Copy the full SHA faaf22cView commit details
Commits on Aug 23, 2023
-
libtorch: fix cuda; troubleshoot packages which don't show up by movi…
…ng them to buildInputs
Connor Baker committedAug 23, 2023 Configuration menu - View commit details
-
Copy full SHA for e988430 - Browse repository at this point
Copy the full SHA e988430View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.