Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nccl-tests: init at 2.13.6 #240015

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Conversation

jmillerpdt
Copy link
Contributor

@jmillerpdt jmillerpdt commented Jun 26, 2023

Description of changes

Adds tests to check both the performance and the correctness of NVIDIA NCCL operations.

Closes Package request: nccl-tests#239212

CC @NixOS/cuda-maintainers @ConnorBaker

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.
$ nix-build --expr 'with (import ./. { config = { allowUnfree = true; cudaSupport = true; }; }).pkgs; cudaPackages.nccl-tests'
/nix/store/l6n4w81qnwb05fpjgg4dv3lnanb40z3g-nccl-tests-2.13.6

@ConnorBaker ConnorBaker self-assigned this Jun 27, 2023
@ConnorBaker ConnorBaker added 6.topic: cuda Parallel computing platform and API 8.has: package (new) This PR adds a new package labels Jun 27, 2023
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 28, 2023
@jmillerpdt jmillerpdt marked this pull request as ready for review June 28, 2023 17:44
Copy link
Contributor

@ConnorBaker ConnorBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this! And sorry about the delay in reviewing.

Overall, looks good, and the result runs as expected. I included a few things I'd like to see addressed before I merge.

pkgs/development/libraries/science/math/nccl/tests.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/science/math/nccl/tests.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/science/math/nccl/tests.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/science/math/nccl/tests.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/science/math/nccl/tests.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/science/math/nccl/tests.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/science/math/nccl/tests.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/science/math/nccl/tests.nix Outdated Show resolved Hide resolved
@jmillerpdt
Copy link
Contributor Author

Thank you for submitting this! And sorry about the delay in reviewing.

Overall, looks good, and the result runs as expected. I included a few things I'd like to see addressed before I merge.

Thank you @ConnorBaker for the review and the suggestions. I believe these have all been addressed.

Copy link
Contributor

@ConnorBaker ConnorBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@ConnorBaker ConnorBaker merged commit 23144ff into NixOS:master Aug 21, 2023
5 checks passed
@jmillerpdt jmillerpdt deleted the init-nccl-tests branch October 18, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cuda Parallel computing platform and API 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Package request: nccl-tests
2 participants