-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nccl-tests: init at 2.13.6 #240015
nccl-tests: init at 2.13.6 #240015
Conversation
9797a55
to
879d640
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting this! And sorry about the delay in reviewing.
Overall, looks good, and the result runs as expected. I included a few things I'd like to see addressed before I merge.
5710de9
to
51eb33e
Compare
51eb33e
to
c19e417
Compare
Thank you @ConnorBaker for the review and the suggestions. I believe these have all been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
Description of changes
Adds tests to check both the performance and the correctness of NVIDIA NCCL operations.
Closes Package request: nccl-tests#239212
CC @NixOS/cuda-maintainers @ConnorBaker
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)