gcc: change "-stage-static" to "-nolibc" and "-stage-final" to "" #240596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
requested review from
adevress,
Ericson2314,
SuperSandro2000,
Synthetica9,
vcunat,
prusnak and
veprbl
|
See #243194 |
ghost
closed this
avnik
pushed a commit
to avnik/nixpkgs
that referenced
this pull request
Oct 14, 2023
This commit is reverted in NixOS#240596 (which must go to staging). (cherry-picked from commit 96a2f1b)
ghost
reopened this
github-actions
bot
added
6.topic: lib
|
Hrm, I thought this was included with one the PRs that got merged, but evidently it was not. |
ghost
marked this pull request as ready for review
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 501-1000
and removed
10.rebuild-linux-stdenv
Artturin
reviewed
Oct 26, 2023
Ericson2314
approved these changes
Oct 26, 2023
Ericson2314
reviewed
Oct 26, 2023
|
@ofborg eval |
This commit changes the target suffix for the first-stage cross compiler from `-stage-static` to `-nolibc`, and eliminates the target suffix from the final-stage cross compiler (previously `-stage-final`). Co-authored-by: Artturi <[email protected]> Co-authored-by: John Ericson <[email protected]>
Ericson2314
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
our cross compiler bootstrap no longer has a "static only" stage. To avoid confusion,
crossStageStaticwas renamedgccWithoutTargetLibc; this is just an attrname so it didn't have to go tostaging. Removing the-stage-staticfrom the correspondingpnamesdoes however have to go tostaging. That's what this PR does.This commit changes the target suffix for the first-stage cross compiler from
-stage-staticto-nolibc, and eliminates the target suffix from the final-stage cross compiler (previously-stage-final).