Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdkafka: 2.1.1 -> 2.2.0 #243630

Closed
wants to merge 1 commit into from
Closed

Conversation

sagikazarmark
Copy link
Member

Description of changes

Update rdkafka to 2.2.0

https://github.com/confluentinc/librdkafka/releases/tag/v2.2.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Signed-off-by: Mark Sagi-Kazar <[email protected]>
@2xsaiko
Copy link
Contributor

2xsaiko commented Jul 15, 2023

Result of nixpkgs-review pr 243630 run on x86_64-linux 1

10 packages failed to build:
  • python310Packages.bytewax
  • python310Packages.bytewax.dist
  • python310Packages.confluent-kafka
  • python310Packages.confluent-kafka.dist
  • python310Packages.streamz
  • python310Packages.streamz.dist
  • python311Packages.confluent-kafka
  • python311Packages.confluent-kafka.dist
  • python311Packages.streamz
  • python311Packages.streamz.dist
33 packages built:
  • ceph (ceph-dev)
  • ceph-client
  • ceph-csi
  • ceph.dev (ceph-dev.dev)
  • ceph.doc (ceph-dev.doc)
  • libceph (ceph.lib ,libceph.dev ,libceph.doc ,libceph.lib ,libceph.man)
  • ceph.man (ceph-dev.man)
  • collectd
  • haskellPackages.haskakafka
  • haskellPackages.haskakafka.doc
  • haskellPackages.hw-kafka-client
  • haskellPackages.hw-kafka-client.doc
  • haskellPackages.hw-kafka-conduit
  • haskellPackages.hw-kafka-conduit.doc
  • haskellPackages.pipes-kafka
  • haskellPackages.pipes-kafka.doc
  • kafka-delta-ingest
  • kcat
  • libserdes
  • libserdes.dev
  • ntopng
  • php81Extensions.rdkafka
  • php82Extensions.rdkafka
  • php83Extensions.rdkafka
  • qemu_full
  • qemu_full.debug
  • qemu_full.ga
  • rdkafka
  • rsyslog
  • sambaFull (samba4Full)
  • sambaFull.dev (samba4Full.dev)
  • sambaFull.man (samba4Full.man)
  • vector

Result of nixpkgs-review pr 243630 run on aarch64-darwin 1

10 packages marked as broken and skipped:
  • collectd
  • kafka-delta-ingest
  • ntopng
  • python310Packages.bytewax
  • python310Packages.bytewax.dist
  • python310Packages.streamz
  • python310Packages.streamz.dist
  • python311Packages.streamz
  • python311Packages.streamz.dist
  • qemu_full
17 packages built:
  • haskellPackages.haskakafka
  • haskellPackages.haskakafka.doc
  • haskellPackages.hw-kafka-client
  • haskellPackages.hw-kafka-client.doc
  • haskellPackages.hw-kafka-conduit
  • haskellPackages.hw-kafka-conduit.doc
  • haskellPackages.pipes-kafka
  • haskellPackages.pipes-kafka.doc
  • kcat
  • libserdes
  • libserdes.dev
  • python310Packages.confluent-kafka
  • python310Packages.confluent-kafka.dist
  • python311Packages.confluent-kafka
  • python311Packages.confluent-kafka.dist
  • rdkafka
  • vector

Copy link
Contributor

@milibopp milibopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Kafka client libraries that depend on librdkafka have to be upgraded along with this to avoid breaking them. The Python library (confluent-kafka) is currently broken, see #246744

@sagikazarmark
Copy link
Member Author

@milibopp unfortunately, I'm not familiar with the python library. I looked at the referenced issues though and it seems like it hasn't been solved upstream yet, so we may have to hold off on merging that for now.

I'm happy to collaborate on upgrades of other packages.

@wegank
Copy link
Member

wegank commented Oct 28, 2023

Already on master, closing.

Also, would you like to have a look at #263612?

@wegank wegank closed this Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants