Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310Packages.anthropic: 0.2.10 -> 0.3.6 #244377

Merged
merged 1 commit into from
Jul 22, 2023
Merged

python310Packages.anthropic: 0.2.10 -> 0.3.6 #244377

merged 1 commit into from
Jul 22, 2023

Conversation

natsukium
Copy link
Member

Changelog: https://github.com/anthropics/anthropic-sdk-python/releases/tag/v0.3.4

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium
Copy link
Member Author

Result of nixpkgs-review pr 244377 run on aarch64-darwin 1

2 packages failed to build:
  • python311Packages.langchain
  • python311Packages.langchain.dist
8 packages built:
  • pentestgpt
  • pentestgpt.dist
  • python310Packages.anthropic
  • python310Packages.anthropic.dist
  • python310Packages.langchain
  • python310Packages.langchain.dist
  • python311Packages.anthropic
  • python311Packages.anthropic.dist

tjni
tjni reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@tjni tjni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Now that What's the reason for not including the tokenizer in the repo? anthropics/anthropic-sdk-python#24 is marked resolved, do tests work again?
  2. They just released 0.3.5 :)

/cc @blaggacao for awareness, that this package, in anthropics/anthropic-sdk-python#50, put an upper bound on pydantic

@natsukium
Copy link
Member Author

eagle eye
I'll try to enable the checkPhase later.

Feel free to ignore the upper bound.
I'll mark it as broken = versionAtLeast pydantic.version "2".

@natsukium natsukium marked this pull request as draft July 20, 2023 10:21
@natsukium natsukium changed the title python310Packages.anthropic: 0.2.10 -> 0.3.4 python310Packages.anthropic: 0.2.10 -> 0.3.6 Jul 22, 2023
@natsukium natsukium marked this pull request as ready for review July 22, 2023 14:48
@SuperSandro2000 SuperSandro2000 merged commit e027293 into NixOS:master Jul 22, 2023
10 of 12 checks passed
@natsukium
Copy link
Member Author

Result of nixpkgs-review pr 244377 run on x86_64-linux 1

2 packages failed to build:
  • python311Packages.langchain
  • python311Packages.langchain.dist
8 packages built:
  • pentestgpt
  • pentestgpt.dist
  • python310Packages.anthropic
  • python310Packages.anthropic.dist
  • python310Packages.langchain
  • python310Packages.langchain.dist
  • python311Packages.anthropic
  • python311Packages.anthropic.dist

@natsukium natsukium deleted the anthropic/update branch July 23, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjni tjni tjni left review comments

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natsukium @tjni @SuperSandro2000