Add pipInstallFlags to all pip install invocations in python hooks #244444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doronbehar
requested changes
Jul 20, 2023
There was a problem hiding this comment.
Also, I this this PR triggers many rebuilds, so I'd make it target branch python-updates that is worked on in #244135 . We could also ask @SuperSandro2000 for a review.
| @@ -25,7 +27,7 @@ pipShellHook() { | |||
| export PYTHONPATH="$tmp_path/@pythonSitePackages@:$PYTHONPATH" | |||
| mkdir -p "$tmp_path/@pythonSitePackages@" | |||
| @pythonInterpreter@ -m pip install -e . --prefix "$tmp_path" \ | |||
| --no-build-isolation >&2 | |||
| --no-build-isolation $pipInstallFlags >&2 | |||
| @@ -33,7 +35,7 @@ setuptoolsShellHook() { | |||
| export PYTHONPATH="$tmp_path/@pythonSitePackages@:$PYTHONPATH" | |||
| mkdir -p "$tmp_path/@pythonSitePackages@" | |||
| eval "@pythonInterpreter@ -m pip install -e . --prefix $tmp_path \ | |||
| --no-build-isolation >&2" | |||
| --no-build-isolation $pipInstallFlags >&2" | |||
There was a problem hiding this comment.
You do have a point about this flag though! And this is a change in behavior that needs to be documented. I also wonder: very few packages depend on setuptoolsBuildHook, so how did this requirement arise for you?
|
Friendly ping @balattar |
|
Closing due to no reply by OP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Resolves #172936
The pipInstallFlags environment variable was only being passed to the
pip-install-hook. This causes other invocations of pip (like insetup-tools-build-hookandpip-buildhook`) to effectively ignore the pipInstallFlags argument to the buildPythonPackage function.This PR resolves the issue by adding the install flags to every pip invocation in the python hooks
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)