Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bibtex-tidy: use buildNpmPackage #246298

Merged
merged 1 commit into from
Aug 1, 2023
Merged

bibtex-tidy: use buildNpmPackage #246298

merged 1 commit into from
Aug 1, 2023

Conversation

dotlambda
Copy link
Member

Description of changes

See #229475.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @bertof who originally packaged it in #213590

@dotlambda dotlambda force-pushed the bibtex-tidy-buildNpmPackage branch from 986502c to 53e5d09 Compare July 31, 2023 05:20
@ofborg ofborg bot requested a review from bertof July 31, 2023 05:40
bertof
bertof approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@bertof bertof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs fine on x86_64-linux and the changes seem ok to me. Thank you for updating the package.

@dotlambda dotlambda merged commit 09f2d76 into NixOS:master Aug 1, 2023
11 of 12 checks passed
@dotlambda dotlambda deleted the bibtex-tidy-buildNpmPackage branch August 1, 2023 14:35
@natsukium natsukium mentioned this pull request Aug 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertof bertof bertof approved these changes

Assignees
No one assigned
Labels
6.topic: nodejs 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
Repackage node2nix packages
Status: Re-packaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotlambda @bertof