Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libfprint-2-tod1-broadcom: init at 5.8.012.0 #246503

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

totoroot
Copy link
Contributor

@totoroot totoroot commented Aug 1, 2023

Description of changes

This adds another driver for libfprint-2-tod1, which is supposed to be used as Touch OEM Drivers (TOD) package in the NixOS module services.fprintd.tod.driver. This enables fingerprint support for the Dell Latitude 7440 and some other notebook models.

I managed to get the driver running by supplying the needed statically linked libraries, but hit a road block when fprintd tries to load the driver's firmware:

○ fprintd.service - Fingerprint Authentication Daemon
     Loaded: loaded (/etc/systemd/system/fprintd.service; linked; preset: enabled)
    Drop-In: /nix/store/if17mdl7z0j9q27m36z6b0gh4jiipvp2-system-units/fprintd.service.d
             └─overrides.conf
     Active: inactive (dead)
       Docs: man:fprintd(1)

Aug 01 07:49:28 nixos systemd[1]: Starting Fingerprint Authentication Daemon...
Aug 01 07:49:28 nixos fprintd[160929]: In cvif_IsUshThere(), cv_get_ush_ver() status: (0x0)
Aug 01 07:49:28 nixos fprintd[160929]: Control Vault getting chip type
Aug 01 07:49:28 nixos fprintd[160929]: Citadel A0 CID7 Chip Found....
Aug 01 07:49:28 nixos fprintd[160929]: Can not find SBI file (bcmsbiCitadelA0_7.otp)
Aug 01 07:49:28 nixos fprintd[160929]: Missing files necessary for complete firmware update
Aug 01 07:49:28 nixos fprintd[160929]:                 FwUpgradeError. Check Firmware Files or CID used or Hardware etc. Error: 0x1c
Aug 01 07:49:28 nixos fprintd[160929]: Ignoring device due to initialization error: An unspecified error occurred!
Aug 01 07:49:28 nixos systemd[1]: Started Fingerprint Authentication Daemon.
Aug 01 07:50:15 nixos systemd[1]: fprintd.service: Deactivated successfully.

When the package is built, the firmware files are copied to the correct location, but it seems like fprintd cannot find them. Any help would be greatly appreciated!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 1, 2023
@totoroot totoroot force-pushed the init/libfprint-2-tod1-broadcom branch from c4c0e47 to b1739d7 Compare August 1, 2023 06:40
@totoroot totoroot changed the title libfprint-2-tod1-broadcom: init at 5.8.012 libfprint-2-tod1-broadcom: init at 5.8.012.0 Aug 1, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/need-some-help-getting-a-new-driver-working-for-fprintd/31157/1

@totoroot
Copy link
Contributor Author

totoroot commented Aug 1, 2023

@abbradar Could you provide some insight? I'm only asking since you are listed as the maintainer of libfprint

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants