Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libnvme: add withDocs #246649

Merged
merged 1 commit into from Aug 29, 2023
Merged

libnvme: add withDocs #246649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkgs/os-specific/linux/libnvme/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@
, stdenv
, swig
, systemd
# ImportError: cannot import name 'mlog' from 'mesonbuild'
, withDocs ? stdenv.hostPlatform.canExecute stdenv.buildPlatform
}:

stdenv.mkDerivation rec {
pname = "libnvme";
version = "1.4";

outputs = [ "out" "man" ];
outputs = [ "out" ] ++ lib.optionals withDocs [ "man" ];

src = fetchFromGitHub {
owner = "linux-nvme";
Expand Down Expand Up @@ -51,7 +53,7 @@ stdenv.mkDerivation rec {

mesonFlags = [
"-Ddocs=man"
"-Ddocs-build=true"
(lib.mesonBool "docs-build" withDocs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If in the future the docs are enabled by default, then this will still work.

];

preConfigure = ''
Expand Down