Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writeDarwinBundle: use binary wrapper #249268

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Commits on Aug 19, 2023

  1. Configuration menu
    Copy the full SHA
    55d5ebb View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. writeDarwinBundle: use binary wrapper

    Previously `writeDarwinBundle` used a handcrafted shell wrapper, however
    this causes issues on Apple Silicon Macs as script-only application
    bundles are always run under Rosetta[0][1].
    
    Replacing the handcrafted shell wrapper with a binary wrapper allows
    apps to run natively instead of requiring Rosetta. However, this means
    we can no longer use `$1` and `$@`.
    
    After checking nearly every current usage of `desktopToDarwinBundle`,
    there were no apps that used `%[fFuU]` before the last argument, meaning
    removing them naively is good enough for the current apps.
    
    [0]: https://developer.apple.com/documentation/apple-silicon/building-a-universal-macos-binary
    [1]: https://stackoverflow.com/a/68208374
    Enzime committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    66884a4 View commit details
    Browse the repository at this point in the history