Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

titanium: use buildNpmPackage #249808

Merged
merged 2 commits into from
Sep 4, 2023
Merged

titanium: use buildNpmPackage #249808

merged 2 commits into from
Sep 4, 2023

Conversation

dotlambda
Copy link
Member

Description of changes

See #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Lord-Valen
Lord-Valen reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@Lord-Valen Lord-Valen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a maintainer. Otherwise this is good.

@natsukium natsukium mentioned this pull request Aug 31, 2023
Open
@dotlambda dotlambda merged commit f53ec4f into NixOS:master Sep 4, 2023
8 checks passed
@dotlambda dotlambda deleted the titanium-buildNpmPackage branch September 4, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lord-Valen Lord-Valen Lord-Valen left review comments

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
6.topic: nodejs 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
Repackage node2nix packages
Status: Re-packaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotlambda @Lord-Valen