Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btc-rpc-explorer: use buildNpmPackage #249844

Merged
merged 1 commit into from
Aug 23, 2023
Merged

btc-rpc-explorer: use buildNpmPackage #249844

merged 1 commit into from
Aug 23, 2023

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Aug 17, 2023 •
edited
Loading

Description of changes

See #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @d-xo who originally packaged it in #104073

@ofborg ofborg bot requested a review from d-xo August 18, 2023 00:05
@dotlambda dotlambda force-pushed the btc-rpc-explorer-buildNpmPackage branch from c7ca64d to 389ced5 Compare August 20, 2023 04:19
@dotlambda dotlambda merged commit 7ceabd1 into NixOS:master Aug 23, 2023
21 checks passed
@dotlambda dotlambda deleted the btc-rpc-explorer-buildNpmPackage branch August 23, 2023 01:53
@natsukium natsukium mentioned this pull request Aug 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-xo d-xo Awaiting requested review from d-xo

Assignees
No one assigned
Labels
6.topic: nodejs 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dotlambda