Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coffeescript: use buildNpmPackage #250008

Merged
merged 1 commit into from
Sep 6, 2023
Merged

coffeescript: use buildNpmPackage #250008

merged 1 commit into from
Sep 6, 2023

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Aug 18, 2023 •
edited
Loading

Description of changes

See #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

closes #252449

@dotlambda dotlambda added the 9.needs: maintainer Package or module needs active maintainers label Aug 18, 2023
@dotlambda dotlambda force-pushed the coffeescript-buildNpmPackage branch 3 times, most recently from 4f95b35 to a49555a Compare August 22, 2023 00:38
This was referenced Aug 31, 2023
Closed
Open
@dotlambda dotlambda removed the 9.needs: maintainer Package or module needs active maintainers label Sep 6, 2023
@ofborg ofborg bot requested a review from cdmistman September 6, 2023 03:22
@dotlambda dotlambda merged commit 8fa0d87 into NixOS:master Sep 6, 2023
8 of 9 checks passed
@dotlambda dotlambda deleted the coffeescript-buildNpmPackage branch September 6, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdmistman cdmistman Awaiting requested review from cdmistman

Assignees
No one assigned
Labels
6.topic: nodejs 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
Repackage node2nix packages
Status: Re-packaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotlambda @cdmistman