Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http-server: use buildNpmPackage #250265

Merged
merged 1 commit into from
Jan 21, 2024
Merged

http-server: use buildNpmPackage #250265

merged 1 commit into from
Jan 21, 2024

Conversation

dotlambda
Copy link
Member

Description of changes

see #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda added the 9.needs: maintainer Package or module needs active maintainers label Aug 19, 2023
@natsukium natsukium mentioned this pull request Aug 31, 2023
Open
@dotlambda dotlambda marked this pull request as ready for review January 21, 2024 00:10
@dotlambda dotlambda merged commit 8648bdc into NixOS:master Jan 21, 2024
23 checks passed
@dotlambda dotlambda deleted the http-server-buildNpmPackage branch January 21, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nodejs 8.has: package (new) 9.needs: maintainer Package or module needs active maintainers 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dotlambda