Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

immich-cli: use buildNpmPackage #250280

Merged
merged 1 commit into from
Aug 21, 2023
Merged

immich-cli: use buildNpmPackage #250280

merged 1 commit into from
Aug 21, 2023

Conversation

dotlambda
Copy link
Member

Description of changes

see #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @felschr who originally packaged it in #187317

@ofborg ofborg bot requested a review from felschr August 20, 2023 01:51
@felschr
Copy link
Member

felschr commented Aug 20, 2023

Result of nixpkgs-review pr 250280 run on x86_64-linux 1

1 package built:
  • immich-cli

felschr
felschr approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@felschr felschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, cli still appears to work.
Would be nice to add the changelog.

pkgs/tools/misc/immich-cli/default.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from felschr August 20, 2023 23:04
@dotlambda dotlambda merged commit 9daeb4c into NixOS:master Aug 21, 2023
22 of 23 checks passed
@dotlambda dotlambda deleted the immich-cli-buildNpmPackage branch August 21, 2023 00:01
@dotlambda dotlambda mentioned this pull request Aug 29, 2023
Closed
16 tasks
@natsukium natsukium mentioned this pull request Aug 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felschr felschr felschr approved these changes

Assignees
No one assigned
Labels
6.topic: nodejs 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotlambda @felschr