Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm-check-updates: use buildNpmPackage #250875

Merged
merged 1 commit into from
Aug 29, 2023
Merged

npm-check-updates: use buildNpmPackage #250875

merged 1 commit into from
Aug 29, 2023

Conversation

dotlambda
Copy link
Member

Description of changes

See #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @flosse who originally packaged it in #4734

@dotlambda dotlambda force-pushed the npm-check-updates-buildNpmPackage branch from 646e9ea to ee5b381 Compare August 23, 2023 01:49
@ofborg ofborg bot requested a review from flosse August 23, 2023 02:10
@Lord-Valen
Copy link
Contributor

Better fix merge conflicts. You just had to touch nodePackages.nix... 😄

@dotlambda dotlambda force-pushed the npm-check-updates-buildNpmPackage branch from ee5b381 to 20a15c7 Compare August 29, 2023 16:01
@dotlambda dotlambda merged commit 4f00a0a into NixOS:master Aug 29, 2023
20 of 21 checks passed
@dotlambda dotlambda deleted the npm-check-updates-buildNpmPackage branch August 29, 2023 21:34
@natsukium natsukium mentioned this pull request Aug 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lord-Valen Lord-Valen Lord-Valen approved these changes

@flosse flosse Awaiting requested review from flosse

Assignees
No one assigned
Labels
6.topic: nodejs 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotlambda @Lord-Valen