Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.rtlcss: use buildNpmPackage #252265

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

Lord-Valen
Copy link
Contributor

@Lord-Valen Lord-Valen commented Aug 30, 2023

Description of changes

See #229475.
Maintainer needed.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Lord-Valen Lord-Valen added the 9.needs: maintainer Package or module needs active maintainers label Aug 30, 2023
@mkg20001
Copy link
Member

is there any reason why not to keep it in nodePackages?

@Lord-Valen
Copy link
Contributor Author

is there any reason why not to keep it in nodePackages?

nodePackages is unmaintainable. A change for one package can and usually will cause merge conflicts for other PRs. It's massive size means autogeneration can take hours. See #229475.

@mkg20001 mkg20001 merged commit e8db8bb into NixOS:master Aug 30, 2023
20 checks passed
@@ -0,0 +1,24 @@
{ buildNpmPackage, fetchFromGitHub, lib, ... }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ buildNpmPackage, fetchFromGitHub, lib, ... }:
{ buildNpmPackage, fetchFromGitHub, lib }:

@Lord-Valen Lord-Valen deleted the npm-rtlcss branch February 5, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants