nodePackages.vsc-leetcode-cli: use buildNpmPackage #252441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
dotlambda
requested changes
Aug 31, 2023
| @@ -0,0 +1,25 @@ | |||
| { buildNpmPackage, fetchFromGitHub, lib, ... }: | |||
There was a problem hiding this comment.
Suggested change
| { buildNpmPackage, fetchFromGitHub, lib, ... }: | |
| { lib | |
| , buildNpmPackage | |
| , fetchFromGitHub | |
| }: |
|
|
||
| buildNpmPackage rec { | ||
| pname = "vsc-leetcode-cli"; | ||
| version = "2021-04-11-unstable"; |
There was a problem hiding this comment.
Suggested change
| version = "2021-04-11-unstable"; | |
| version = "unstable-2021-04-11"; |
pkgs/top-level/all-packages.nix
Outdated
| @@ -36397,6 +36397,8 @@ with pkgs; | |||
|
|
|||
| vpcs = callPackage ../applications/virtualization/vpcs { }; | |||
|
|
|||
| vsc-leetcode-cli = callPackage ../applications/misc/vsc-leetcode-cli { }; | |||
There was a problem hiding this comment.
Suggested change
| vsc-leetcode-cli = callPackage ../applications/misc/vsc-leetcode-cli { }; | |
| vsc-leetcode-cli = callPackage ../tools/misc/vsc-leetcode-cli { }; |
because it's a CLI tool
Lord-Valen
force-pushed
the
npm-leetcode-cli
branch
from
2d3bc9d
to
d233899
Compare
dotlambda
reviewed
Aug 31, 2023
|
|
||
| buildNpmPackage { | ||
| pname = "vsc-leetcode-cli"; | ||
| version = "unstable-2021-04-11"; |
There was a problem hiding this comment.
Why don't we use the most recent commit and call it 2.8.1. Pretty sure that corresponds to what's on NPM.
There was a problem hiding this comment.
Because it isn't 2.8.1? Seems like 2.8.1 was published to NPM but not pushed to GitHub. The package.json on GitHub still has version 2.8.0 whereas NPM has ... 2.8.1. There may be no other differences and I don't care to diff it but even that one change is enough of a distinguishing characteristic for me.
|
|
||
| meta = with lib; { | ||
| description = "A CLI tool for leetcode.com"; | ||
| homepage = "https://github.com/leetcode-tools/leetcode-cli#readme"; |
There was a problem hiding this comment.
Suggested change
| homepage = "https://github.com/leetcode-tools/leetcode-cli#readme"; | |
| homepage = "https://github.com/leetcode-tools/leetcode-cli"; |
dotlambda
reviewed
Aug 31, 2023
| description = "A CLI tool for leetcode.com"; | ||
| homepage = "https://github.com/leetcode-tools/leetcode-cli#readme"; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers; [ cpcloud ]; |
dotlambda
reviewed
Aug 31, 2023
| @@ -0,0 +1,25 @@ | |||
| { buildNpmPackage, fetchFromGitHub, lib }: | |||
Lord-Valen
force-pushed
the
npm-leetcode-cli
branch
2 times, most recently
from
d921997
to
5528b08
Compare
dotlambda
requested changes
Sep 8, 2023
dotlambda
force-pushed
the
npm-leetcode-cli
branch
from
5528b08
to
72ed25b
Compare
dotlambda
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
See #229475.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)