Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.surge: use buildNpmPackage #252460

Merged
merged 1 commit into from
Sep 8, 2023
Merged

nodePackages.surge: use buildNpmPackage #252460

merged 1 commit into from
Sep 8, 2023

Conversation

Lord-Valen
Copy link
Contributor

Description of changes

See #229475.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium natsukium mentioned this pull request Aug 31, 2023
Open
@ofborg ofborg bot requested a review from MoritzBoehme August 31, 2023 20:10
@wegank
Copy link
Member

wegank commented Sep 7, 2023

Perhaps add an alias in pkgs/development/node-packages/aliases.nix?

@ofborg ofborg bot requested a review from MoritzBoehme September 8, 2023 18:32
@wegank
Copy link
Member

wegank commented Sep 8, 2023

@ofborg build surge-cli surge-cli.passthru.tests

@wegank
Copy link
Member

wegank commented Sep 8, 2023

Result of nixpkgs-review pr 252460 run on x86_64-darwin 1

1 package built:
  • surge-cli

@wegank wegank merged commit 8193698 into NixOS:master Sep 8, 2023
22 of 23 checks passed
@Lord-Valen Lord-Valen deleted the npm-surge branch February 5, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank approved these changes

@MoritzBoehme MoritzBoehme MoritzBoehme approved these changes

Assignees
No one assigned
Labels
6.topic: nodejs 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lord-Valen @wegank @MoritzBoehme