Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.terser: use buildNpmPackage #252499

Merged
merged 1 commit into from
Sep 13, 2023
Merged

nodePackages.terser: use buildNpmPackage #252499

merged 1 commit into from
Sep 13, 2023

Conversation

Lord-Valen
Copy link
Contributor

Description of changes

See #229475.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Lord-Valen Lord-Valen requested a review from talyz August 31, 2023 06:25
@natsukium
Copy link
Member

from ofborg

at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-5/pkgs/servers/web-apps/discourse/default.nix:226:7:

          225|       nodePackages.uglify-js
          226|       nodePackages.terser
             |       ^
          227|       nodePackages.patch-package

@natsukium natsukium mentioned this pull request Aug 31, 2023
Open
@natsukium
Copy link
Member

natsukium commented Sep 2, 2023 •
edited by wegank
Loading

@ofborg build terser

@natsukium
Copy link
Member

Result of nixpkgs-review pr 252499 run on aarch64-darwin 1

1 package built:
  • terser

natsukium
natsukium approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 8, 2023
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Sep 8, 2023
@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Sep 9, 2023
dotlambda
dotlambda approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the merge conflict.

@delroth delroth added the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Sep 13, 2023
@delroth delroth removed the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Sep 13, 2023
@dotlambda
Copy link
Member

@ofborg build terser

@dotlambda dotlambda merged commit ea36f70 into NixOS:master Sep 13, 2023
9 checks passed
@Lord-Valen Lord-Valen deleted the npm-terser branch February 5, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

@wegank wegank wegank approved these changes

@dotlambda dotlambda dotlambda approved these changes

@talyz talyz Awaiting requested review from talyz

Assignees
No one assigned
Labels
6.topic: nodejs 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
Repackage node2nix packages
Status: Re-packaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lord-Valen @natsukium @dotlambda @wegank @delroth