treewide: migrate packages to by-name hierarchy #254417
Conversation
AndersonTorres
force-pushed
the
migrate-to-by-name
branch
from
fafe4c9
to
8660987
Compare
AndersonTorres
force-pushed
the
migrate-to-by-name
branch
2 times, most recently
from
a61d618
to
2247510
Compare
|
I think it was discussed at NixCon that we should move to the new schema using automation (where possible) to avoid the overhead of many PRs. You also did some cleanup so in this case this is probably fine. |
|
This is an opportunity to review my own code and not lose some tracks. I have found some packages that should be removed and others needing more attention, like TLOE. Also there is no problem in some manual intervention. |
|
@ofborg build pkgsLLVM.mksh mksh |
|
Yeah so I will work on updating #211832 next, which is the automated mass migration. I wouldn't want people to have to do this manually to save on both reviewer and contributor time. I think it's fine if you happen to clean up the code or update the versions anyways though. Since you did the work here already I guess it's fine, but others should definitely not be encouraged to do this manually until the automated migration is done (it doesn't work automatically for all packages) 🙂 |
AndersonTorres
force-pushed
the
migrate-to-by-name
branch
from
40ee2e5
to
e043620
Compare
|
I opened #254632 to have this written down |
|
OK, I will stop this thread for now and concentrate in the version bumps. |
|
@ofborg build xorriso dosbox-staging |
AndersonTorres
force-pushed
the
migrate-to-by-name
branch
from
a62ef50
to
f3f0a4d
Compare
|
Are you intending on having this reviewed and merged after all? Or are you using this as a testing ground before splitting it into smaller cleanup PRs? If so this should probably be turned into a draft. |
|
Both |
AndersonTorres
force-pushed
the
migrate-to-by-name
branch
from
f3f0a4d
to
9c45581
Compare
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
AndersonTorres
force-pushed
the
migrate-to-by-name
branch
2 times, most recently
from
43e9994
to
1fc3406
Compare
AndersonTorres
force-pushed
the
migrate-to-by-name
branch
6 times, most recently
from
eacf01c
to
9c6cc4e
Compare
AndersonTorres
force-pushed
the
migrate-to-by-name
branch
from
9c6cc4e
to
97ef0a2
Compare
- multiple outputs - add meta.mainProgram - migrate to by-name
- add meta.mainProgram - migrate to by-name
- rec-less
- finalAttrs - no nested with
- factor out tests
AndersonTorres
force-pushed
the
migrate-to-by-name
branch
from
bde7f53
to
35e8531
Compare
Description of changes
The ones maintained by @AndersonTorres
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)