-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chromium{Beta,Dev},google-chrome-{beta,dev}: drop #261870
Conversation
d370c4c
to
4cb2fb2
Compare
4cb2fb2
to
9e7dbf1
Compare
Besides @emilylange I'm currently more or less the only active maintainer. I don't have the capacity to maintain dev or beta myself (I've been doing stable bumps pretty much exclusively) and don't see any real interest from other maintainers or outside contributors, as such I support this removal. |
Not a maintainer, but I am also in favor of this. As these are not built by Hydra they are not useful for casual testing of newer versions and people who hack on Chromium or its packaging don't need them as they'll change the chromium derivation directly. |
What would be the best way to override the version of Chrome/Chromium? Would it involve overriding the upstream-info.nix file used for the package? I'm not sure how to do this without getting billions of errors after attempting to rebuild. |
@Nanotwerp^ I am not quite sure if you are asking how to override the version from within nixpkgs, e.g. for a PR, or as a consumer/user of nixpkgs. Either way, I would suggest that you create a new issue instead, so we don't end up creating a huge thread here, related to, but not quite the topic of this PR. Thank you very much :) |
This is mainly due to the lack of maintenance in nixpkgs. `google-chrome-{beta,dev}` depend on `chromium{Beta,Dev}`'s version info. `chromium{Beta,Dev}` are rarely updated and explicitly blocklisted by `hydra.nixos.org`, meaning they are almost always outdated and not cached in `cache.nixos.org`. `chromium{Beta,Dev}` were intended to fix the build derivation of each new major release (if something broke) *before* stable reached that new major release. Allowing for fast bumps in nixpkgs, especially if the stable bump contains very important critical security fixes. Something that can easily be replicated by using an early-stable release or by manually entering a dev/beta version string in stable's `upstream-info.nix`. This resolves exposing end-users to outdated and vulnerable `google-chrome-{beta,dev}` and `chromium{Beta,Dev}` versions.
9e7dbf1
to
59719f7
Compare
Today is the deadline day (2023-10-29 UTC), as mentioned in my opening comment. There were no objection to drop I am, however, a bit disappointed, that none of the other maintainers (@primeos and @thefloweringash) responded or at least acknowledged it in any way. But I am afraid that's something I expected, given their lack of activity in the past months. Merging. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/fresh-google-chrome-dev-in-nixos/35124/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Description of changes
This is mainly due to the lack of maintenance in nixpkgs.
google-chrome-{beta,dev}
depend onchromium{Beta,Dev}
's version info.chromium{Beta,Dev}
are rarely updated and explicitly blocklisted byhydra.nixos.org
, meaning they are almost always outdated and not cached incache.nixos.org
.chromium{Beta,Dev}
were intended to fix the build derivation of each new major release (if something broke) before stable reached that new major release.Allowing for fast bumps in nixpkgs, especially if the stable bump contains very important critical security fixes.
Something that can easily be replicated by using an early-stable release or by manually entering an dev/beta version string in stable's
upstream-info.nix
.This resolves exposing end-users to outdated and vulnerable
google-chrome-{beta,dev}
andchromium{Beta,Dev}
versions.Deadline: 2023-10-29 UTC (which is one day before the "Restrict all breaking changes with the exception of desktop environments" in our
23.11
release schedule #258640).Ref: #255197
cc (
chromium{,Beta,Dev}
): @primeos @thefloweringash @networkException @emilylangecc (
google-chrome{,-beta,-dev}
): @primeosThings done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)