Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging-next] sage, rpy2: test fixes #262290

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

collares
Copy link
Member

@collares collares commented Oct 20, 2023

Description of changes

rpy2 and Sage tests currently fail in staging next due to matplotlib and rpy2 upgrades. I've also took the opportunity to introduce a nbclassic dependency to work an issue with Notebook 7 which came up in the previous staging-next merge (see issue below).

Works around #258458.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@collares
Copy link
Member Author

@ofborg build sageWithDoc

@ofborg ofborg bot requested a review from joelmo October 20, 2023 16:03
@collares collares merged commit af038be into NixOS:staging-next Oct 20, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant