Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud26: 26.0.7 -> 26.0.8, nextcloud27: 27.1.2 -> 27.1.3 #263979

Merged
merged 4 commits into from
Oct 30, 2023
Merged

nextcloud26: 26.0.7 -> 26.0.8, nextcloud27: 27.1.2 -> 27.1.3 #263979

merged 4 commits into from
Oct 30, 2023

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 28, 2023 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from schneefux, globin and bachp October 28, 2023 16:30
bachp
bachp approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks passed.

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 29, 2023
@wegank wegank mentioned this pull request Oct 29, 2023
Closed
13 tasks
@Ma27 Ma27 mentioned this pull request Oct 29, 2023
Closed
13 tasks
@dotlambda
Copy link
Member

These NixOS tests fail:

  • nixosTests.nextcloud.with-declarative-redis-and-secrets26
  • nixosTests.nextcloud.with-declarative-redis-and-secrets27
  • nixosTests.nextcloud.with-postgresql-and-redis26
  • nixosTests.nextcloud.with-postgresql-and-redis27

@SuperSandro2000
Copy link
Member Author

That's strange because it works locally for me, probably just the test being flaky.

@ofborg test nextcloud

@Ma27
Copy link
Member

Ma27 commented Oct 30, 2023

These probably fail because of #216989 because postgresql. This is not a Nextcloud issue though.

Ma27
Ma27 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, test failures are unrelated. If noone disagrees, I'd merge tonight.

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Oct 30, 2023
@Ma27 Ma27 merged commit 64319d8 into NixOS:master Oct 30, 2023
33 of 34 checks passed
@github-actions
Copy link
Contributor

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-263979-to-release-23.05 origin/release-23.05
cd .worktree/backport-263979-to-release-23.05
git checkout -b backport-263979-to-release-23.05
ancref=$(git merge-base 72a0006e04a5c5ac9c7101a06695fc8da1f153d7 91239bc459a8a182305a43885f602183adafdba9)
git cherry-pick -x $ancref..91239bc459a8a182305a43885f602183adafdba9

@Ma27
Copy link
Member

Ma27 commented Oct 30, 2023

Will backport tomorrow unless someone's faster.

@Ma27 Ma27 mentioned this pull request Oct 31, 2023
Merged
13 tasks
@SuperSandro2000 SuperSandro2000 deleted the nextcloud27 branch November 5, 2023 16:07
@SuperSandro2000
Copy link
Member Author

It would be cool if someone could fix those tests....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@bachp bachp bachp approved these changes

@schneefux schneefux Awaiting requested review from schneefux

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SuperSandro2000 @dotlambda @Ma27 @bachp @delroth