linuxPackages.evdi: mark broken on linux 6.6 #266060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyroussel
added
the
0.kind: ZHF Fixes
alyssais
reviewed
Nov 7, 2023
ofborg
bot
added
10.rebuild-darwin: 0
anthonyroussel
force-pushed
the
fix/evdi-linux-6_6
branch
from
b83738e
to
f200612
Compare
Fixes NixOS#265868 `evdi` kernel module is incompatible with Linux 6.6, so mark it as broken.
The build fails with:
```console
module/evdi_fb.c: In function 'evdifb_create':
module/evdi_fb.c:427:21:
error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
427 | info->fbops = efbdev->fb_ops;
| ^
````
A resolution is to treat discard-qualifiers warnings as non-error.
See https://hydra.nixos.org/build/239848621
anthonyroussel
force-pushed
the
fix/evdi-linux-6_6
branch
from
f200612
to
44964d2
Compare
alyssais
approved these changes
Nov 7, 2023
Infinidoge
approved these changes
Nov 7, 2023
delroth
added
the
12.approvals: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
ZHF: #265948
Fixes Hydra failures:
evdikernel module is incompatible with Linux 6.6, so mark it as brokenThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)