prayer: use html-tidy 5.6 #266129
prayer: use html-tidy 5.6 #266129
Conversation
ofborg
bot
added
8.has: package (new)
ghost
added
the
0.kind: ZHF Fixes
There was a problem hiding this comment.
This does unbreak https://hydra.nixos.org/build/239231197, but when I test it I only get an empty page in response. I can't see any issues in the strace however and it does reply with a http 200 success, so it may be a user error on my part.
It seems the homepage is dead, and there are a bunch of assets marked executable. Fixing this is not a blocker IMO.
| license = licenses.libpng; # very close to it - the 3 clauses are identical | ||
| homepage = "http://html-tidy.org"; | ||
| platforms = platforms.all; | ||
| maintainers = with maintainers; []; |
There was a problem hiding this comment.
The html-tidy/{default,5.6}.nix diff is nearly empty, but i see this downgrade has no maintainer. Consider adding yourself, otherwise @edwtjo would you mind maintaining this one in addition to the up to date one?
|
You're right. I just looked into getting this to build again, but there seems to be a lot of other stuff wrong with this now. the icons folder is placed right next to bin and share etc. it should probably be somewhere below share/prayer/ it also contains an etc which should probably not exist. I can confirm the reply from the server is empty. There's also a few hardcoded absolute paths in one of the config files in the etc folder, like /usr/bin/passwd. There's also no maintainer and it hasn't been touched in almost 4 years. It just happen to break when html-tidy got updated. I guess it's not worth the effort since nobody seems to use it. What do you think? |
|
Oops. Misclick. |
|
Oh wow. Here's to more facts.
Yeah I think it's overdue to be marked broken, or even just removed entirely. Edit: See #266532 |
|
This time intentionally. |
Description of changes
The prayer package requires an older version of html-tidy as dependency due to prayer relying on private library functions of libtidy which have become hidden in versions greater 5.6 of html-tidy.
ZHF: #265948
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)