Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apt-cacher-ng: fix build with ubuntu patch for HAVE_STRLCPY #266542

Closed
wants to merge 1 commit into from
Closed

apt-cacher-ng: fix build with ubuntu patch for HAVE_STRLCPY #266542

wants to merge 1 commit into from

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Nov 9, 2023

Description of changes

fixes apt-cacher-ng build with the ubuntu upstream patch.

Upstream issue: https://bugs.launchpad.net/ubuntu/+source/apt-cacher-ng/+bug/2036822

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@makefu makefu added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 9, 2023
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 9, 2023
nevivurn
nevivurn approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@nevivurn nevivurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the exact same patch as #266030, so it should work.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 10, 2023
@makefu
Copy link
Contributor Author

makefu commented Nov 10, 2023

Seems like the exact same patch as #266030, so it should work.

you are right, lets get your PR merged

@makefu makefu closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevivurn nevivurn nevivurn approved these changes

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makefu @nevivurn @delroth