-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree-sitter-grammars: Add koka #267000
tree-sitter-grammars: Add koka #267000
Conversation
Result of 2 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @akirak, looks good to me! I did just make one small change to the queries, so you might want to update the rev to include that. There's also a fix for the scoped
keyword coming (see helix-editor/helix#8727 (comment)).
I've marked this PR as a draft for updating the branch. I'll unmark it when it's ready. |
6e22f54
to
1b1e239
Compare
Result of 2 packages built:
|
@mtoohey31 I've updated the PR, but I don't know when to undraft it (maybe wait for |
Thanks @akirak, I've added the scoped change to main. There's just two final points I'm waiting for feedback on in the Helix PR, so I'll let you know once those are resolved. |
1b1e239
to
305c427
Compare
This language has been integrated into helix (see helix-editor/helix@2e4653e), so I think it is ready to get merged. Thank you for your patient work, @mtoohey31 and others! |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3658 |
Thanks for paying attention to that PR! Sorry that I forgot to ping you even though I said I would 🤦 There may be more updates once I get around to addressing mtoohey31/tree-sitter-koka#2, but it's probably best to include that in a future PR, cause I'm not sure when I'll get around to it. Would you mind bumping the revision of the grammar in the PR to the latest one on main? There have been a couple of fixes since the earlier rev that would be nice to include. |
305c427
to
336269c
Compare
Yes! I forgot that. Sorry for being dumb. I have updated the JSON to reflect your latest main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! Thanks!
@ofborg build tree-sitter-grammars.tree-sitter-koka |
Thanks! |
Description of changes
A tree-sitter grammar for Koka: https://github.com/mtoohey31/tree-sitter-koka
Koka is a strongly typed functional-style language with effect types and handlers.
Adding this grammar to nixpkgs will promote development of editor integrations of the language. There is a GitHub Discussion on the parser: koka-lang/koka#370
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)