Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging-next] python310Packages.pymupdf: override mupdf python bindings version to ensure match #267684

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[staging-next] python310Packages.pymupdf: override mupdf python bindings version to ensure match #267684

merged 1 commit into from
Nov 16, 2023

Conversation

lilyinstarlight
Copy link
Member

Description of changes

Fixes broken python310Packages.pymupdf build on Hydra: https://hydra.nixos.org/build/240865389

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@lilyinstarlight lilyinstarlight changed the title [staging-next] python310Packages.pymupdf: override mupdf python bindings version to ensure they are build with the same python as pymupdf [staging-next] python310Packages.pymupdf: override mupdf python bindings version to ensure python version match Nov 15, 2023
@lilyinstarlight lilyinstarlight changed the title [staging-next] python310Packages.pymupdf: override mupdf python bindings version to ensure python version match [staging-next] python310Packages.pymupdf: override mupdf python bindings version to ensure match Nov 15, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 15, 2023
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 15, 2023
@ofborg ofborg bot requested a review from teto November 15, 2023 16:03
@RaitoBezarius RaitoBezarius merged commit 9387784 into NixOS:staging-next Nov 16, 2023
26 checks passed
@lilyinstarlight lilyinstarlight deleted the fix/pymupdf-python-version-oopsy branch November 16, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilyinstarlight @RaitoBezarius @dotlambda @delroth