Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.deap: fix build #268633

Merged
merged 2 commits into from
Nov 21, 2023
Merged

python311Packages.deap: fix build #268633

merged 2 commits into from
Nov 21, 2023

Conversation

GetPsyched
Copy link
Member

Description of changes

Fix failing build for python311Packages.deap. Removed nose for checks and add pytest as a dependency.

ZHF: #265948

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@GetPsyched GetPsyched added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 20, 2023
@ofborg ofborg bot requested a review from PsyanticY November 20, 2023 04:31
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 20, 2023
@GetPsyched
Copy link
Member Author

ofborg shouldn't add the by: package maintainer label as it's misleading in this case. I added myself as the maintainer in this PR but I'm pretty sure that tag is for existing maintainers pushing updates, not me.

Also, consider removing @PsyanticY from maintainers as they've not been active on GitHub for over a year judging from their contribution list?

@GetPsyched
Copy link
Member Author

This PR also fixes sklearn-deap which depends on this package. Unaware if there are more packages that depend on this.

@GetPsyched
Copy link
Member Author

Thanks for the review, @natsukium!

Also, is the label not required?

@risicle
Copy link
Contributor

risicle commented Nov 20, 2023

If you're running the test via unittests why do you need pytestCheckHook?

@natsukium
Copy link
Member

Also, is the label not required?

This is a fix for the master and is not required for staging.

@GetPsyched
Copy link
Member Author

Also, is the label not required?

This is a fix for the master and is not required for staging.

What about ZHF? I put the label because of the cutoff thinking that it wouldn't be backported otherwise

@GetPsyched
Copy link
Member Author

If you're running the test via unittests why do you need pytestCheckHook?

I had added pytest initially since that was a missing dependency causing the build to fail. Wasn't aware that the hook didn't need to co-exist with a checkPhase; in hindsight, it makes a lot of sense lol.

@natsukium
Copy link
Member

Once branch-off is done, we need to backport. #258640

@GetPsyched
Copy link
Member Author

Once branch-off is done, we need to backport. #258640

Ah, I didn't know it was postponed, thanks.

@natsukium
Copy link
Member

Result of nixpkgs-review pr 268633 at c5a9008 run on x86_64-linux 1

4 packages built successfully:
  • python310Packages.deap
  • python310Packages.sklearn-deap
  • python311Packages.deap
  • python311Packages.sklearn-deap

natsukium
natsukium approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit 371c442 into NixOS:master Nov 21, 2023
22 checks passed
@GetPsyched
Copy link
Member Author

Thanks a lot for the reviews!

@GetPsyched GetPsyched deleted the python/deap branch April 21, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

@PsyanticY PsyanticY Awaiting requested review from PsyanticY

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GetPsyched @risicle @natsukium