Purge stdenv.cross #26884
Merged
Purge stdenv.cross #26884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
added
2.status: work-in-progress
|
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @pSub and @vcunat to be potential reviewers. |
Mic92
reviewed
Jun 27, 2017
| , icuSupport ? false, icu ? null }: | ||
| }: |
Ericson2314
force-pushed
the
purge-stdenv-cross
branch
from
82cb4d8
to
162b442
Compare
0xABAB
approved these changes
Jun 28, 2017
Ericson2314
force-pushed
the
purge-stdenv-cross
branch
from
162b442
to
0e765ee
Compare
|
@bjornfor that's my fault with the sed before the manual fix up. I hope there's a way to filter-branch to fix that.... |
|
@Ericson2314. No problem. I think you can script the git filter-branch thing. |
I'm guessing the salient aspect here is not cross compiling itself, but just whether the host platform is MinGW, so I simplified the logic accordingly
cc-wrapper will define environment variables matching those now
Ericson2314
force-pushed
the
purge-stdenv-cross
branch
from
c3a4603
to
721f7c5
Compare
Ericson2314
force-pushed
the
purge-stdenv-cross
branch
from
721f7c5
to
307cba5
Compare
Ericson2314
force-pushed
the
purge-stdenv-cross
branch
from
307cba5
to
9f156f4
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
stdenv.crossis vague: better to usebuildPlatform,hostPlatformortargetPlatform. This is a rather tedious task so anyone that sees this, feel free to push to this PR (if you are a contributor) or send a PR against the PR (if you are not).Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)CC @bjornfor @matthewbauer @Dridus