Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moonlander: Update num-bigint to fix build #269934

Closed
wants to merge 1 commit into from

Conversation

Nebucatnetzer
Copy link
Contributor

@Nebucatnetzer Nebucatnetzer commented Nov 25, 2023

Description of changes

Update num-bigint dependency to fix the build for moonlander.
Broken since for both aarch64-linux and x86_64-linux
https://hydra.nixos.org/build/241198586
https://hydra.nixos.org/build/241077856

It builds now but seg faults when we try to run it.
Wasn't able to get a proper debug log.
It works on 23.05 on x86_64

@azahi JFYI

#ZurichZHF

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@azahi azahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds but segfaults on launch and I don't have time now to debug that. Maybe we should remove this package altogether because it looks like it's been abandoned upstream.

[azahi@eonwe:~/.cache/nixpkgs-review/pr-269934]$ ./results/moonlander/bin/moonlander
[INFO  moonlander] Moonlander 0.1.0
[INFO  moonlander] Using configuration file "/home/azahi/.config/moonlander/moonlander.toml"
[INFO  moonlander] Opening new tab about:moonlander
Segmentation fault (core dumped)

@Nebucatnetzer
Copy link
Contributor Author

Fine with me.
Do you want to remove it since you added it?

@azahi
Copy link
Member

azahi commented Nov 26, 2023

@Nebucatnetzer thanks for the heads up. I will handle this in #270135.

@azahi azahi closed this Nov 26, 2023
@azahi azahi mentioned this pull request Nov 27, 2023
13 tasks
@Nebucatnetzer Nebucatnetzer deleted the fix-moonlander branch December 29, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants