python311Packages.cvxopt: use LP64 blas on darwin; fix build #270016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
0.kind: ZHF Fixes
ghost
requested review from
darwin builds were using the ILP64 openblas library which causes the build to segufault in the unittests, which might be why the unit tests were disabled on darwin... this change aligns darwin to the linux build to use LP64 blas / lapack libraries. this also aligns with the assert at the top of the file which asserts blas and lapack are LP64. the darwin unit test is re-enabled and passes.
ofborg
bot
added
6.topic: darwin
ofborg
bot
added
10.rebuild-linux: 11-100
and removed
10.rebuild-linux: 0
ghost
mentioned this pull request
13 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3003 |
This was referenced Nov 29, 2023
pbsds
approved these changes
Nov 30, 2023
|
@emilytrau if you have a chance to look at this, i'm trying to get this package in as it silently (and not so silently) breaks a bunch of consumers on darwin. thx! |
|
Result of 32 packages marked as broken and skipped:
4 packages failed to build:
24 packages built:
|
|
Successfully created backport PR for |
Merged
1 task
|
woot! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
darwin builds were using the ILP64 openblas library which causes the build to segufault in the unittests, which might be why the unit tests were disabled on darwin.
ILP64 is unsupported so it was a bug for darwin to use it in the first place.
this change aligns darwin to the linux build to use LP64 blas / lapack libraries. this also aligns with the assert at the top of the file which asserts blas and lapack are LP64. nixpkgs blas & lapack point to openblasCompat which is the openblas LP64, the opeblas package is ILP64. numpy and most (all) other math python packages require LP64.
the darwin unit test is enabled and now passes after this change as do the consumers of this package which were segfaulting in their unit tests.
Fixes: #271105
ZHF: #265948
https://hydra.nixos.org/build/241904734
note: the hydra failure is for python311Packages.cvxpy but that is just because it's unit tests run and were segfaulting in cvxopt
Result of
nixpkgs-review pr 270016run on x86_64-darwin 133 packages marked as broken and skipped:
28 packages built:
Result of
nixpkgs-review pr 270016run on x86_64-linux 128 packages marked as broken and skipped:
48 packages built:
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.