Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-23.11] moonlander: drop #270527

Closed

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to release-23.11, triggered by a label in #270480.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

(cherry picked from commit da55691)
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
13 tasks
@fabianhjr
Copy link
Member

Unsure about this drop @figsoda

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 28, 2023
@azahi
Copy link
Member

azahi commented Nov 28, 2023

This drop is a part of ZHF.

@figsoda
Copy link
Member

figsoda commented Nov 28, 2023

It's probably better to mark it as broken before completely dropping the package

@azahi
Copy link
Member

azahi commented Nov 28, 2023

It's probably better to mark it as broken before completely dropping the package

I'm pretty sure that this package is not used by many, if any users at all. Marking it as broken won't change the fact that it's abandoned upstream and probably won't ever be fixed.

@fabianhjr
Copy link
Member

Looking at Hydra

Last successful build 2023-10-21 21:55:31 First broken build 2023-11-16 23:46:21 This build 2023-11-21 15:08:47
Succeededbuild 239073895 Failedbuild 241077856 Failedbuild 241775011

First broken build was 2023-11-16, I think I would defer to figsoda suggestion of marking as broken on 23.11 rather than removal since the removal would normally not be backportable.

@azahi
Copy link
Member

azahi commented Nov 28, 2023

Alright, I'm not sure how to proceed here, since the package was already removed in master. Let's say we close this PR, do we need to make another one targeting the release branch and just mark it broken there, ignoring the master?

@fabianhjr
Copy link
Member

Yes, another merge request targeting release-23.11 marking as broken.

Will close this one and feel free to ping me to merge the new PR.

@fabianhjr fabianhjr closed this Nov 28, 2023
@azahi azahi mentioned this pull request Nov 28, 2023
13 tasks
@figsoda figsoda deleted the backport-270480-to-release-23.11 branch November 28, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants