Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kotlin-native: update darwin hashes; fix build #270594

Merged
merged 1 commit into from Nov 28, 2023
Merged

kotlin-native: update darwin hashes; fix build #270594

merged 1 commit into from Nov 28, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 28, 2023

the last version auto update #264833 only updated the linux x64 hash and neglected the 2 macos ones. the auto update will likely break again soon as the next version was released 5 days ago

this updates the other two hashes using the published sha256 digests and converts them to an sri.

# aarch64 darwin
nix-hash --to-sri --type sha256 630e883bca63d02f571dfcd5b21728be4a050545c9dca8b1846a326c14452f65
# x64 darwin
nix-hash --to-sri --type sha256 9a70e2f1d3020f31ac74f743d5dc3860c07101fa3916fc0325553f7b0ef4cfd5

testing: build passed on x64 darwin

ZHF: #265948
https://hydra.nixos.org/build/240783888

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

last version update #264833
only updated the linux x64 hash and neglected the 2 macos ones.

this updates the other two hashes using the published sha256 digests
https://github.com/JetBrains/kotlin/releases/tag/v1.9.20
and converts them to an sri.

testing: build passed on x64 darwin
@ghost ghost added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign backport release-23.11 labels Nov 28, 2023
@ghost ghost mentioned this pull request Nov 28, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 28, 2023
@ghost ghost requested a review from fabianhjr November 28, 2023 12:10
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 28, 2023
@fabianhjr
Copy link
Member

Hi, thanks for the fix, I apologize for the issues caused since I should have looked into the diff before merging.

I haven't been using kotlin lately, would you be interested in adding yourself as a maintainer of this package? (You would be notified on automatic updates)

@ghost
Copy link
Author

ghost commented Nov 28, 2023

Hi, thanks for the fix, I apologize for the issues caused since I should have looked into the diff before merging.

I haven't been using kotlin lately, would you be interested in adding yourself as a maintainer of this package? (You would be notified on automatic updates)

no worries. i don't use kotlin either. i've just been fixing broken packages for the upcoming release. #265948

@fabianhjr
Copy link
Member

Thanks for the help with ZHF, merging as is then. :3

@fabianhjr fabianhjr merged commit bee5e83 into NixOS:master Nov 28, 2023
33 of 34 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

@ghost ghost deleted the kotlin-native-hash-update branch November 29, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants