sonic-server: fix build with clang 12+ #270634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyroussel
added
backport release-23.11
0.kind: ZHF Fixes
ofborg
bot
added
11.by: package-maintainer
|
looks like the build is failing for rocksdb on darwin before the link step. |
ghost
reviewed
Nov 28, 2023
Comment on lines
+34
to
+36
| env = lib.optionalAttrs stdenv.cc.isClang { | ||
| NIX_LDFLAGS = "-l${stdenv.cc.libcxx.cxxabi.libName}"; | ||
| }; |
There was a problem hiding this comment.
stdenv.cc.isClang can be true while stdenv.cc.libxx is null so i've been using (stdenv.cc.libcxx != null) as the check.
nix-repl> builtins.currentSystem
"x86_64-linux"
nix-repl> clang16Stdenv.cc.libcxx
null
nix-repl> clang16Stdenv.cc.isClang
truealso NIX_LDFLAGS will link -lc++abi into everything it builds, there seem to be various things getting built by cargo in this package so this could be undesirable.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix the build on Darwin with this workaround: #166205
ZHF: #265948
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.