c3c: unstable-2021-07-30 -> 0.5.5

[SMFloris]

Update c3c compiler to the newest released stable version.

Description of changes

Updated the package to the latest upstream stable version.

Added a patch in order for CMake to be able to find the ldd libs since on Nix the ldd lib is split from the llvm libs.

Latest changelog of the c3c compiler

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

[SMFloris]

So it appears we still have the following things that fail:

• on aarch64-linux: it does not even build -- will investigate
• on aarch64-darwin: build succeeds, but 2 tests out of 733 fail
• on x86_x64-darwin: build succeeds, but 1 test out of 733 fail

It does seem like the tests that fail are known issues in this release. It is expected that a new language that didn't even hit 1.0 will have these, but I will investigate more as time allows.

The thing that does concern me is the aarch64-linux build.This should probably work; will check upstream as well.

[Ashvith10]

@SMFloris is this PR in draft, or ready for merge? I was wondering that at least for the time being, we could make the x86-64-linux version work properly.

[SMFloris]

@Ashvith10 , x86-64-linux works fine as far as I can tell. The other platforms not sure.

I will get back to fixing the other platforms at some point in the future.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3718

[eclairevoyant]

Thanks for the contribution, and apologies that this wasn't seen sooner. Some feedback/questions below:

stale review

[tomodachi94]

Lgtm, package builds and outputs correct version:

$ /nix/store/7j6za7z0lfcyx87cmi3534fvs5siyy4k-c3c-0.5.5/bin/c3c --version
C3 Compiler Version:       0.5.5 (prerelease)
Installed directory:       /nix/store/7j6za7z0lfcyx87cmi3534fvs5siyy4k-c3c-0.5.5/bin/
LLVM version:              17.0.6
LLVM default target:       x86_64-unknown-linux-gnu

[SMFloris]

Is it possible to have this merged before 24.05? :D

[eclairevoyant]

Seems like tests are failing on all platforms on except x86_64-linux - not sure about the format-string test failures on darwin, but linking hello world in the tests seems to fail on aarch64-linux

[kashw2]

This PR should also fix the build failure in Hydra and contribute towards #309482

Resolved