Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-typify: init at 0.0.14 #273252

Merged
merged 2 commits into from
Dec 26, 2023
Merged

cargo-typify: init at 0.0.14 #273252

merged 2 commits into from
Dec 26, 2023

Conversation

david-r-cox
Copy link
Member

@david-r-cox david-r-cox commented Dec 10, 2023 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@david-r-cox
Copy link
Member Author

Result of nixpkgs-review pr 273252 run on x86_64-linux 1

1 package built:
  • cargo-typify

@david-r-cox
Copy link
Member Author

Result of nixpkgs-review pr 273252 run on x86_64-linux 1

1 package built:
  • cargo-typify

@david-r-cox david-r-cox marked this pull request as ready for review December 10, 2023 03:58
@david-r-cox david-r-cox mentioned this pull request Dec 10, 2023
Closed
13 tasks
@david-r-cox
Copy link
Member Author

Result of nixpkgs-review pr 273252 run on x86_64-linux 1

1 package built:
  • cargo-typify

eclairevoyant
eclairevoyant suggested changes Dec 11, 2023
View reviewed changes
pkgs/by-name/ca/cargo-typify/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ca/cargo-typify/package.nix Outdated Show resolved Hide resolved
@eclairevoyant
Copy link
Contributor

Thanks for the contribution! Some nits above.

@david-r-cox
Copy link
Member Author

Thanks for the feedback @eclairevoyant! TIL about lib.getExe

@david-r-cox
Copy link
Member Author

Result of nixpkgs-review pr 273252 run on x86_64-linux 1

1 package built:
  • cargo-typify

@matthiasbeyer matthiasbeyer merged commit f1e4636 into NixOS:master Dec 26, 2023
23 checks passed
@matthiasbeyer
Copy link
Contributor

Result of nixpkgs-review pr 273252 run on x86_64-linux 1

1 package built:
  • cargo-typify

@david-r-cox david-r-cox deleted the cargo-typify branch December 27, 2023 17:09
@david-r-cox david-r-cox mentioned this pull request Jun 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank left review comments

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@eclairevoyant eclairevoyant Awaiting requested review from eclairevoyant

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@david-r-cox @eclairevoyant @matthiasbeyer @wegank @NixOSInfra