Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixpkgs-hammering: unstable-2023-03-09 -> unstable-2023-11-06 #273672

Merged
merged 1 commit into from
Dec 19, 2023
Merged

nixpkgs-hammering: unstable-2023-03-09 -> unstable-2023-11-06 #273672

merged 1 commit into from
Dec 19, 2023

Conversation

onemoresuza
Copy link
Contributor

@onemoresuza onemoresuza commented Dec 12, 2023 •
edited
Loading

Description of changes

Allow nixpkgs-hammering to work on packages that pass a function to
mkDerivation --- see here.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from figsoda December 12, 2023 04:07
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 12, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3081

@onemoresuza
Copy link
Contributor Author

Result of nixpkgs-review pr 273672 run on x86_64-linux 1

1 package built:
  • nixpkgs-hammering

1 similar comment
@quantenzitrone
Copy link
Contributor

Result of nixpkgs-review pr 273672 run on x86_64-linux 1

1 package built:
  • nixpkgs-hammering

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1307

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 13, 2023
pbsds
pbsds approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 273672 run on x86_64-linux 1

1 package built:
  • nixpkgs-hammering

Tested this and the old version and can confirm support for finalAttrs is added in this bump.

@onemoresuza onemoresuza added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 17, 2023
@NickCao NickCao merged commit ee7cca0 into NixOS:master Dec 19, 2023
30 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@github-actions github-actions bot mentioned this pull request Dec 19, 2023
Merged
1 task
@onemoresuza onemoresuza deleted the nixpkgs-hammering branch December 19, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantenzitrone quantenzitrone quantenzitrone approved these changes

@pbsds pbsds pbsds approved these changes

@figsoda figsoda Awaiting requested review from figsoda

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@onemoresuza @nixos-discourse @quantenzitrone @pbsds @delroth @NickCao