nixos/lib/make-disk-image: Create build products metadata for hydra

[mweinelt]

For hydra to expose built images for direct download, listing the relevant files in nix-support/hydra-build-products is required.

This could be useful to reuse our images on the LXD imageserver. https://hydra.nixos.org/build/244751553

$ cat result/nix-support/hydra-build-products
file qcow2-image /nix/store/c8jila306khspz9b4qbfgxvvrvd6w7fx-nixos-disk-image/nixos.qcow2
$ file /nix/store/c8jila306khspz9b4qbfgxvvrvd6w7fx-nixos-disk-image/nixos.qcow2
/nix/store/c8jila306khspz9b4qbfgxvvrvd6w7fx-nixos-disk-image/nixos.qcow2: QEMU QCOW Image (v3), 3638558720 bytes (v3), 3638558720 bytes

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[mkg20001]

Fyi I already run an LXD Image Server under images.mkg20001.io using the lxd-image-server module (config https://gist.github.com/mkg20001/342b8aef64cc2553964a3c8473fe3ee5)

Maybe you could re-use some of that

[mweinelt]

The idea is to get this into the upstream image server, so it will have better discoverability, but thanks for your offer.

lxc/lxc-ci#786 (comment)

[mkg20001]

Ah, ok

Very nice.

[adamcstephens]

Thanks!

[adamcstephens]

Can, should, we backport this so we can get VM images for 23.11 up?

[mweinelt]

Yeah, we probably should. I don't think it will cause regressions, but we could maybe let it sit for a few days and see what happens on master.

[github-actions]

Successfully created backport PR for release-23.11:

• [Backport release-23.11] nixos/lib/make-disk-image: Create build products metadata for hydra #277209