guymager: init at 0.8.13 #278529
guymager: init at 0.8.13 #278529
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
|
@ofborg eval |
ofborg
bot
added
8.has: package (new)
wegank
removed
the
12.approvals: 1
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 278529
x86_64-linux
✅ 2 packages built:
- guymager
- libguytools
|
will merge in 24 hours unless someone comments more |
| mainProgram = "libguytools"; | ||
| homepage = "https://libguytools.sourceforge.io"; | ||
| maintainers = with lib.maintainers; [ d3vil0p3r ]; | ||
| platforms = lib.platforms.unix; |
There was a problem hiding this comment.
https://github.com/NixOS/nixpkgs/pull/278529/checks?check_run_id=32689131906
is darwin supported ?
There was a problem hiding this comment.
I don't have an endpoint where to actually test it.
There was a problem hiding this comment.
The build failure is just due to GHC not being present in the cache. (and it doesn't build in the timeout for PRs)
There was a problem hiding this comment.
Either wait until GHC is built successfully, merge anyway or find someone with a darwin builder.
There was a problem hiding this comment.
looks like its broken on darwin anyway
error: builder for '/nix/store/sn4lpclhdid87q30g0dlyvbwjkr0a3ns-libguytools-2.1.0.drv' failed with exit code 2;
last 25 log lines:
> (*ToolSignalLocal.pLogFn)(Error, pthread_self(), pFileName, pFunctionName, LineNr, pFormat, VaList);
> ^~~~~~~~~~~~~~
> toolsignal.cpp:271:20: error: incompatible pointer to integer conversion assigning to 'unsigned long long' from 'pthread_t _Nonnull' (aka '_opaque_pthread_t *')
> *pThreadId = pthread_self();
> ^~~~~~~~~~~~~~
> 2 errors generated.
> make: *** [Makefile:421: toolsignal.o] Error 1
> make: *** Waiting for unfinished jobs....
> toolsysinfo.cpp:40:10: fatal error: 'linux/if.h' file not found
> #include <linux/if.h>
> ^~~~~~~~~~~~
> toollog.cpp:116:87: error: cast from pointer to smaller type 'unsigned int' loses information
> wr += (size_t) snprintf (&LogLineHeader[wr], sizeof(LogLineHeader)-wr, "%08X ", (unsigned int)pthread_self());
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> toollog.cpp:130:18: error: use of undeclared identifier 'fopen64'; did you mean 'fopen'?
> pFile = fopen64 (pLogFilename, "a");
> ^~~~~~~
> fopen
> /nix/store/lq1j6jzsd0av6cm3yd9fxkjbw1mj2991-apple-sdk-10.14.6/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:153:7: note: 'fopen' declared here
> FILE *fopen(const char * __restrict __filename, const char * __restrict __mode) __DARWIN_ALIAS_STARTING(__MAC_10_6, __IPHONE_2_0, __DARWIN_ALIAS(fopen));
> ^
> 1 error generated.
> make: *** [Makefile:415: toolsysinfo.o] Error 1
> 2 errors generated.
> make: *** [Makefile:404: toollog.o] Error 1
For full logs, run 'nix-store -l /nix/store/sn4lpclhdid87q30g0dlyvbwjkr0a3ns-libguytools-2.1.0.drv'.
error: 1 dependencies of derivation '/nix/store/cpccgqf4yzaihq4v0bmmc98icdalyr55-review-shell.drv' failed to build
Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/278529
--------- Report for 'x86_64-darwin' ---------
1 package marked as broken and skipped:
guymager
1 package failed to build:
libguytools
maybe easier to just mark is as broken on darwin, file an issue upstream
There was a problem hiding this comment.
Issue reported to the guymager developer by email
There was a problem hiding this comment.
According to Guymager maintainer, here the statement:
'''
Compiling Guymager will probably lead to a many errors, as the hardware recognition works completely different on the Linux and the Darwin kernels. Guymager includes functions for detecting block devices on Linux, but not on Darwin. The same is true for Windows: There's no support for it in Guymager, i.e. hardware recognition won't work.
'''
I changed platforms.unix to platforms.linux.
|
@ofborg build libguytools |
wegank
added
the
12.approvals: 1
wegank
removed
the
12.approvals: 1
ofborg
bot
added
10.rebuild-darwin: 0
|
@D3vil0p3r sorry, few last things, I've noticed that commit order is not right, |
|
@kirillrdy can you check now please? PS: not clear what about the error on your last logs. |
|
You need to rebase on master, the libbfio package is not included in your branch. |
Rebased to master. Let me know if it's ok. |
|
@D3vil0p3r thank you for your patience! and thank @FliegendeWurst for a review |
|
Successfully created backport PR for |
To be checked in #81418
Depends on:
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.