Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alacritty: fix darwin build #279907

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

happysalada
Copy link
Contributor

Description of changes

fix darwin build by using a newer version of the sdk, the solution was contributed by @reckenrode, thank you!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@happysalada
Copy link
Contributor Author

Result of nixpkgs-review pr 279907 run on x86_64-darwin 1

2 packages built:
  • alacritty
  • alacritty.terminfo

Copy link
Member

@sikmir sikmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 279907 run on x86_64-darwin 1

2 packages built:
  • alacritty
  • alacritty.terminfo

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 9, 2024
Copy link
Contributor

@reckenrode reckenrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 9, 2024
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 9, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jan 9, 2024
@khaneliman
Copy link
Contributor

khaneliman commented Jan 10, 2024

Result of nixpkgs-review pr 279907 run on aarch64-darwin 1

Not picking up for some reason with nixpkgs-review, but nix build .#alacritty works fine and alacritty runs.

@delroth delroth added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Jan 10, 2024
@happysalada happysalada merged commit 1ee8cbd into NixOS:master Jan 10, 2024
27 of 28 checks passed
@happysalada happysalada deleted the fix_alacritty_darwin branch January 10, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants