-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stm32cubemx: wrap with FHSEnv #280833
stm32cubemx: wrap with FHSEnv #280833
Conversation
bab099c
to
4af6da8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested running the application using nixpkgs-review
.
Tested creating a new project, and generating the code. The login window opened, it didn't take in my key presses very well. I had to type the same key multiple times before it accepted a key. Very annoying for the password, but I would consider this a bug in the app, not the nix configuration.
From what I can tell, it's working as expected, and the mentioned bug is resolved.
I found copy/paste to be best solution for credentials input. Thanks for testing and review. |
4af6da8
to
4df662e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Thanks for updating the platforms
.
Everything looks good to me.
I'm not certain if the commit history is correct. Should changing the platforms
be in it's own commit?
I squashed it, but I guess it would make more sense to have separate commit now that I think more about it. |
Yeah, my comment was more for future reviewers. In case they don't see that it's been changed. Maybe it's something they would want. |
4df662e
to
2769038
Compare
Understand, added separate commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Thanks
Description of changes
As of recently STM32CubeMX is using JxBrowser for, now mandatory, user authentication.
Same browser is extracted from STM32CubeMX install binaries into ~/.stm32cubemx directory and depends on the system shared libraries.
This PR wrapps STM32CubeMX with FHSEnv in order call JxBrowser.
Package remains mostly the same except a minor change where stdenv is replaced by stdenvNoCC.
STM32CubeMX login page takes a while to appear on Wayland (Sway) but works mostly fine.
Fixes: #272342
cc @angaz @wucke13
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.