-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gosmee: init at 0.21.0 #284789
gosmee: init at 0.21.0 #284789
Conversation
1b940bc
to
d9a0dcf
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3492 |
d9a0dcf
to
b0edd5a
Compare
@SuperSandro2000 updated, thanks for the review 👼🏼 |
Could we get this into NixOS 24.05? It would be really helpful since the npm module is not in nixpkgs either. |
6ac0961
to
6bd03bf
Compare
pkgs/by-name/go/gosmee/package.nix
Outdated
nativeBuildInputs = [ installShellFiles ]; | ||
|
||
postPatch = '' | ||
printf ${version} > $sourceRoot/gosmee/templates/version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
printf ${version} > $sourceRoot/gosmee/templates/version | |
mkdir -p $sourceRoot/gosmee/templates | |
printf ${version} > $sourceRoot/gosmee/templates/version |
source root is source
Running phase: patchPhase
/nix/store/wq046wv3s3h4m2n9ak3j534di2pzra93-stdenv-linux/setup: line 114: source/gosmee/templates/version: No such file or directory
/nix/store/wq046wv3s3h4m2n9ak3j534di2pzra93-stdenv-linux/setup: line 131: pop_var_context: head of shell_variables not a function context
error: builder for '/nix/store/l759i5krlyliwbk7lr0jdg3cj4qn0rnf-gosmee-0.21.0.drv' failed with exit code 1;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in postPatch
, PWD
already points to /build/source
and sourceRoot
points to source
, so it fails anyway.
Signed-off-by: Vincent Demeester <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of changes
This adds a new package,
gosmee
to nixpkgs.This also adds @chmouel as a maintainer of this package.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.