Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbd: init at 1.37 #290280

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

sbd: init at 1.37 #290280

wants to merge 1 commit into from

Conversation

D3vil0p3r
Copy link
Member

Description of changes

The official website tigerteam.se (not more available) had also latest version 1.37, that should be the version used in Kali Linux. Not sure if a good idea could be to upload this latest version to the packetstormsecurity website, that was the main website where the devs of sbd uploaded the different versions of sbd (except the last one).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@D3vil0p3r D3vil0p3r marked this pull request as ready for review February 20, 2024 21:36
@D3vil0p3r D3vil0p3r requested a review from a user February 20, 2024 21:36
pkgs/by-name/sb/sbd/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sb/sbd/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sb/sbd/package.nix Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Feb 21, 2024

what's wrong with just using netcat?

@ghost
Copy link

ghost commented Feb 21, 2024

the unix and darwin builds are basically identical and windows isn't listed in supported platforms so just build with unix target
{ lib
, stdenv
, fetchurl
}:

let
  archiveUrl = url: "https://web.archive.org/web/20230802015002/${url}";
in
stdenv.mkDerivation (finalAttrs: {
  pname = "sbd";
  version = "1.37";

  src = fetchurl {
    url = archiveUrl "http://www.tigerteam.se/dl/sbd/sbd-${finalAttrs.version}.tar.gz";
    hash = "sha256-Qt5Q3PynV80DAXxuVqx6L4dTKgjnBDQjzSDZEf1kX10=";
  };

  makeFlags = [
    "CC=cc"
    "PREFIX=${placeholder "out"}"
  ];

  buildFlags = [
    "unix"
  ];

  meta = with lib; {
    description = "Netcat-clone, portable, offers strong encryption - features AES-128-CBC + HMAC-SHA1 encryption, program execution, choosing source port, continuous reconnection with delay and more";
    mainProgram = "sbd";
    homepage = archiveUrl "http://www.tigerteam.se/dl/sbd";
    license = licenses.gpl2Plus;
    maintainers = with maintainers; [ d3vil0p3r ];
    platforms = platforms.unix;
  };
})

@D3vil0p3r D3vil0p3r changed the title sbd: init at 1.36 sbd: init at 1.37 Feb 21, 2024
@D3vil0p3r D3vil0p3r requested review from dotlambda and a user February 21, 2024 18:17
homepage = "https://packetstormsecurity.com/UNIX/netcat/";
license = licenses.gpl2Plus;
maintainers = with maintainers; [ d3vil0p3r ];
platforms = platforms.unix;
Copy link

@ghost ghost Feb 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
platforms = platforms.unix;
platforms = platforms.unix;

this needs to get changed or buildFlags needs to get changed. have you tried to build for win32?
I tried to build pkgsCross.mingwW64.sbd and pkgsCross.mingw32.sbd and both fail to build.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the home page should be https://web.archive.org/web/20220626230420/http://www.tigerteam.se/dl/sbd/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-mno-cygwin is deprecated and it should be removed. After that, for Windows, it is needed to find a way to include windows libraries like winsock.h.

@ghost
Copy link

ghost commented Feb 24, 2024

still not sure how this is better than netcat -- i'm not going to merge this. also just saw the matrix discussion on the review requests channel.

@D3vil0p3r
Copy link
Member Author

@a-n-n-a-l-e-e netcat has not encryption (and authentiication controls) so in an untrustworthy network the usage of vanilla netcat could be problematic. Unlike netcat, sbd offers some encryption on data flow. So, this is one use case. I understand the discussion on Matrix but I work in the InfoSec field so I understand the needs of a pentester, architect, blue teamer wherease people not working in this field cannot understand, mostly because InfoSec field is very huge. Feel free to tell your point, if you think it is a bad idea, I can close the PR.

@D3vil0p3r D3vil0p3r force-pushed the patch-7 branch 2 times, most recently from 2761bae to c3547eb Compare February 24, 2024 08:07
@ghost
Copy link

ghost commented Feb 25, 2024

you also have a PR for #288104 which seems to be a slightly modified version of sbd in this PR. not sure why both are necessary. [edit] or any, there seem to be many ways to create encrypted connections between machines these days -- heck, can even just run ssh as a non-root user.

@ghost ghost mentioned this pull request Feb 25, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.05 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants